Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformity of CC#121 reset all controllers #227

Closed
jpcima opened this issue Dec 8, 2019 · 3 comments
Closed

Conformity of CC#121 reset all controllers #227

jpcima opened this issue Dec 8, 2019 · 3 comments
Assignees
@Wohlstand

Comments

@jpcima
Copy link
Collaborator

jpcima commented Dec 8, 2019

I encountered the following information from the GM standard document.
We are resetting Volume and Pan, and this seems against the standard recommendation.

The Association of Music Electronics Industry (AMEI, formerly the Japan MIDI
Standard Committee) has proposed that the following parameters specifically be left
unchanged upon receipt of a Reset All Controllers message. The MMA has not yet
officially adopted this recommendation but it is unlikely that following this
recommendation would cause serious incompatibilities. The MMA is expected to
respond on this issue for both GM and non-GM devices shortly.
Do not Reset:
• Program change
• Bank Select (#0 and #32)
• Volume (#7)
• Pan (#10)
• Effects Controllers #91-95 (not a GM control)
• Sound controllers #70-79 (not a GM Control)
• Other Channel mode messages (#120, #122-#127)
@Wohlstand
Copy link
Owner

We are resetting Volume and Pan, and this seems against the standard recommendation.

For a MIDI-side reset, call do that, however, for sequencer needs, it's NEED to reset everything to avoid glitches are may become as a big pain.

Wohlstand added a commit that referenced this issue Sep 2, 2020
@Wohlstand
Fixed an incorrect logic of CC121
add55f6 
Issue #227
@Wohlstand
Copy link
Owner

Okay, just now I made CC121 to don't reset volume (CC7) and Brightness (CC75).

@Wohlstand Wohlstand self-assigned this Sep 2, 2020
Wohlstand added a commit to Wohlstand/ZMusic that referenced this issue Sep 28, 2020
@Wohlstand
Update libADLMIDI up to 1.5.0
8a24b91 
## 1.5.0   2020-09-28
 * Drum note length expanding is now supported in real-time mode (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Channels manager has been improved (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Nuked OPL3 1.8 emulator got some optimizations ported from 1.7 where they are was applied previously (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Reworked rhythm-mode percussions system, WOPL banks with rhythm-mode percussions
 * Added Public Domain Opal OPL3 emulator made by Reality (a team who originally made the Reality Adlib Tracker) (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added LGPL licensed JavaOPL3 emulator made by Robson Cozendey in Java and later rewritten into C++ for GZDoom (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Fully rewritten an embedded bank database format, embedded banks now supports a wider set (more than 127:127 instruments in one bank)
 * Improved accuracy of the DMX volume model, include the buggy AM interpretation
 * Improved accuracy of Apogee volume model, include the bug of AM instruments
 * Improved accuracy of the Win9X volume model
 * Removed C++ extras. C++-bounded instruments tester is useless since a real-time MIDI API can completely replace it
 * Added AIL volume model
 * Added Generic FM variant of Win9X volume model
 * Fixed an incorrect work of CC-121 (See Wohlstand/libADLMIDI#227 for details)
 * Added HMI volume model (Thanks to [Alexey Khokholov](https://github.com/nukeykt) for help with research!)
 * Added frequency models, assigned to every volume model: AIL, HMI, DMX, Apogee, 9X, and the Generic formula
Wohlstand added a commit to Wohlstand/ZMusic that referenced this issue Sep 28, 2020
@Wohlstand
Update libOPNMIDI library to 1.5.0
1a595df 
## 1.5.0   2020-09-28
 * Drum note length expanding is now supported in real-time mode (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added support for OPNA chip with Neko Project II Kai YM2602 emulator usage (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added VGM file dumper which allows to output OPN2 commands into VGM file. (A new MIDI to VGM tool is now created with basing on libOPNMIDI)
 * Fixed an incorrect work of CC-121 (See Wohlstand/libADLMIDI#227 for details)
 * Internality has been refactored and improved
@Wohlstand Wohlstand mentioned this issue Sep 28, 2020
Merged
coelckers pushed a commit to ZDoom/ZMusic that referenced this issue Oct 4, 2020
@Wohlstand @coelckers
Update libADLMIDI up to 1.5.0
1d4a016 
## 1.5.0   2020-09-28
 * Drum note length expanding is now supported in real-time mode (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Channels manager has been improved (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Nuked OPL3 1.8 emulator got some optimizations ported from 1.7 where they are was applied previously (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Reworked rhythm-mode percussions system, WOPL banks with rhythm-mode percussions
 * Added Public Domain Opal OPL3 emulator made by Reality (a team who originally made the Reality Adlib Tracker) (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added LGPL licensed JavaOPL3 emulator made by Robson Cozendey in Java and later rewritten into C++ for GZDoom (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Fully rewritten an embedded bank database format, embedded banks now supports a wider set (more than 127:127 instruments in one bank)
 * Improved accuracy of the DMX volume model, include the buggy AM interpretation
 * Improved accuracy of Apogee volume model, include the bug of AM instruments
 * Improved accuracy of the Win9X volume model
 * Removed C++ extras. C++-bounded instruments tester is useless since a real-time MIDI API can completely replace it
 * Added AIL volume model
 * Added Generic FM variant of Win9X volume model
 * Fixed an incorrect work of CC-121 (See Wohlstand/libADLMIDI#227 for details)
 * Added HMI volume model (Thanks to [Alexey Khokholov](https://github.com/nukeykt) for help with research!)
 * Added frequency models, assigned to every volume model: AIL, HMI, DMX, Apogee, 9X, and the Generic formula
coelckers pushed a commit to ZDoom/ZMusic that referenced this issue Oct 4, 2020
@Wohlstand @coelckers
Update libOPNMIDI library to 1.5.0
72c23d9 
## 1.5.0   2020-09-28
 * Drum note length expanding is now supported in real-time mode (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added support for OPNA chip with Neko Project II Kai YM2602 emulator usage (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added VGM file dumper which allows to output OPN2 commands into VGM file. (A new MIDI to VGM tool is now created with basing on libOPNMIDI)
 * Fixed an incorrect work of CC-121 (See Wohlstand/libADLMIDI#227 for details)
 * Internality has been refactored and improved
drfrag666 pushed a commit to drfrag666/gzdoom that referenced this issue Oct 4, 2020
@Wohlstand @drfrag666
Update libADLMIDI up to 1.5.0
a4643a8 
## 1.5.0   2020-09-28
 * Drum note length expanding is now supported in real-time mode (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Channels manager has been improved (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Nuked OPL3 1.8 emulator got some optimizations ported from 1.7 where they are was applied previously (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Reworked rhythm-mode percussions system, WOPL banks with rhythm-mode percussions
 * Added Public Domain Opal OPL3 emulator made by Reality (a team who originally made the Reality Adlib Tracker) (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added LGPL licensed JavaOPL3 emulator made by Robson Cozendey in Java and later rewritten into C++ for GZDoom (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Fully rewritten an embedded bank database format, embedded banks now supports a wider set (more than 127:127 instruments in one bank)
 * Improved accuracy of the DMX volume model, include the buggy AM interpretation
 * Improved accuracy of Apogee volume model, include the bug of AM instruments
 * Improved accuracy of the Win9X volume model
 * Removed C++ extras. C++-bounded instruments tester is useless since a real-time MIDI API can completely replace it
 * Added AIL volume model
 * Added Generic FM variant of Win9X volume model
 * Fixed an incorrect work of CC-121 (See Wohlstand/libADLMIDI#227 for details)
 * Added HMI volume model (Thanks to [Alexey Khokholov](https://github.com/nukeykt) for help with research!)
 * Added frequency models, assigned to every volume model: AIL, HMI, DMX, Apogee, 9X, and the Generic formula

# Conflicts:
#	libraries/adlmidi/adldata.cpp
#	libraries/adlmidi/adldata.hh
#	libraries/adlmidi/adlmidi.hpp
drfrag666 pushed a commit to drfrag666/gzdoom that referenced this issue Oct 4, 2020
@Wohlstand @drfrag666
Update libOPNMIDI library to 1.5.0
91a8a5e 
## 1.5.0   2020-09-28
 * Drum note length expanding is now supported in real-time mode (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added support for OPNA chip with Neko Project II Kai YM2602 emulator usage (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added VGM file dumper which allows to output OPN2 commands into VGM file. (A new MIDI to VGM tool is now created with basing on libOPNMIDI)
 * Fixed an incorrect work of CC-121 (See Wohlstand/libADLMIDI#227 for details)
 * Internality has been refactored and improved
drfrag666 pushed a commit to drfrag666/gzdoom that referenced this issue Oct 4, 2020
@Wohlstand @drfrag666
Update libADLMIDI up to 1.5.0
e6ce41b 
## 1.5.0   2020-09-28
 * Drum note length expanding is now supported in real-time mode (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Channels manager has been improved (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Nuked OPL3 1.8 emulator got some optimizations ported from 1.7 where they are was applied previously (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Reworked rhythm-mode percussions system, WOPL banks with rhythm-mode percussions
 * Added Public Domain Opal OPL3 emulator made by Reality (a team who originally made the Reality Adlib Tracker) (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added LGPL licensed JavaOPL3 emulator made by Robson Cozendey in Java and later rewritten into C++ for GZDoom (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Fully rewritten an embedded bank database format, embedded banks now supports a wider set (more than 127:127 instruments in one bank)
 * Improved accuracy of the DMX volume model, include the buggy AM interpretation
 * Improved accuracy of Apogee volume model, include the bug of AM instruments
 * Improved accuracy of the Win9X volume model
 * Removed C++ extras. C++-bounded instruments tester is useless since a real-time MIDI API can completely replace it
 * Added AIL volume model
 * Added Generic FM variant of Win9X volume model
 * Fixed an incorrect work of CC-121 (See Wohlstand/libADLMIDI#227 for details)
 * Added HMI volume model (Thanks to [Alexey Khokholov](https://github.com/nukeykt) for help with research!)
 * Added frequency models, assigned to every volume model: AIL, HMI, DMX, Apogee, 9X, and the Generic formula

# Conflicts:
#	libraries/adlmidi/adldata.cpp
#	libraries/adlmidi/adldata.hh
#	libraries/adlmidi/adlmidi.hpp
drfrag666 pushed a commit to drfrag666/gzdoom that referenced this issue Oct 4, 2020
@Wohlstand @drfrag666
Update libOPNMIDI library to 1.5.0
87d46dd 
## 1.5.0   2020-09-28
 * Drum note length expanding is now supported in real-time mode (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added support for OPNA chip with Neko Project II Kai YM2602 emulator usage (Thanks to [Jean Pierre Cimalando](https://github.com/jpcima) for a work!)
 * Added VGM file dumper which allows to output OPN2 commands into VGM file. (A new MIDI to VGM tool is now created with basing on libOPNMIDI)
 * Fixed an incorrect work of CC-121 (See Wohlstand/libADLMIDI#227 for details)
 * Internality has been refactored and improved
@Wohlstand
Copy link
Owner

Closed due to no response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wohlstand Wohlstand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wohlstand @jpcima