Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of README on Pypi #38

Closed
pombredanne opened this issue Jul 30, 2016 · 14 comments
Closed

Display of README on Pypi #38

pombredanne opened this issue Jul 30, 2016 · 14 comments
Assignees
Labels

Comments

@pombredanne
Copy link
Collaborator

pombredanne commented Jul 30, 2016

See https://pypi.python.org/pypi/pyahocorasick/1.1.1
This is not looking good.
There are some limits to what ReST features Pypi supports.
The issue is likely around links:

@pombredanne
Copy link
Collaborator Author

This may help https://mg.pov.lt/restview/

@WojciechMula WojciechMula self-assigned this Aug 2, 2016
@pombredanne
Copy link
Collaborator Author

Note that I played a bit with this this week-end trying to find where in the README ReST there is something that makes Pypi choke. There is something for sure and restview pointed to errors though I could not tell which one exactly...

@WojciechMula
Copy link
Owner

@pombredanne Maybe we could we use shorter README for PyPI? Just an introduction and the link to readthedocs.org.

@pombredanne
Copy link
Collaborator Author

Maybe we could we use shorter README for PyPI? Just an introduction and the link to readthedocs.org.

Definitely. This is redundant now. Let me streamline this and send a PR

@pombredanne pombredanne self-assigned this Aug 6, 2016
WojciechMula added a commit that referenced this issue Aug 6, 2016
@WojciechMula
Copy link
Owner

Thanks a lot! Your contribution in docs in priceless.

Is it possible to an update existing version of package on PyPI? Or we have to make a new release?

@pombredanne
Copy link
Collaborator Author

The simplest is to publish a new dot version. And this make sense since the code was updated too.

@pombredanne
Copy link
Collaborator Author

You wrote:

Thanks a lot! Your contribution in docs in priceless.

Thank you for your appreciation! it's not like I am putting lipstick on a bullddog: your code is great. Some decent doc is what will make it known.

I am also a selfish bastard: since I am using this library seriously now, I want it to be successful and healthy: with a good looking and decent doc, the likeliness some other folks will use it increases and more users may contribute to its well being ;)

@WojciechMula
Copy link
Owner

Hmm, still doesn't look good. Maybe we should remove from setup.py option long_description? The homepage of package is displayed on PyPI, for a potential user checking out the docs would cost one additional click.

@WojciechMula
Copy link
Owner

@pombredanne Thank you for kind word about the code. :) And you're perfectly right, a documentation is the ad of module. It should be nice and clean.

I wish I could spend more time on this project (and other side projects), but shortage of time is terrible. Moreover, my doctors say that I must not spend whole day at front of computer. :)

@pombredanne
Copy link
Collaborator Author

Maybe we should remove from setup.py option long_description

Let me craft a simple long description just for Pypi.

pombredanne added a commit that referenced this issue Aug 7, 2016
 * refine setup.py such that it does not truncate the README
   when creating a long_description. Tested with @mgedmin restview
 * update the description
 * use single quotes throughout setup.py
 * bump version to 1.1.3
 * various other minor improvements to the README doc
@pombredanne
Copy link
Collaborator Author

pombredanne commented Aug 7, 2016

@WojciechMula this is because the setup.py tries to truncate the readme. I made some changes and tested them here by updating manually the long description on Pypi: https://pypi.python.org/pypi/pyahocorasick/1.1.2

If you have no objections, I can push a new release to Pypi. For now I made these changes in the aptly numbered #42 PR.

WojciechMula added a commit that referenced this issue Aug 7, 2016
#38 Improve Pypi long description and refine README
@WojciechMula
Copy link
Owner

Now looks OK, great! Of course, please upgrade PyPI.

@pombredanne
Copy link
Collaborator Author

I tagged 1.1.3 and pushed a new Pypi release with python setup.py clean --all sdist --formats=bztar,gztar,zip register upload
It is there: https://pypi.python.org/pypi/pyahocorasick/1.1.3

@pombredanne
Copy link
Collaborator Author

I ended up repushing a new 1.1.5 release because of the bad URL fixed 2144668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants