Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different end of lines format shall be supported for all distributions #22

Closed
WojciechRynczuk opened this issue May 14, 2017 · 1 comment
Assignees
Milestone

Comments

@WojciechRynczuk
Copy link
Owner

Regardless of the distribution different end of lines shall be supported.

Currently, the Windows version expects '\r\n' while the Linux one expects '\n'.
In fact, Linux users often use '\r\n' at the end of the line so as the log would be nicely formatted by a terminal.

@WojciechRynczuk WojciechRynczuk added this to the v3.0.1 milestone May 14, 2017
WojciechRynczuk added a commit that referenced this issue May 31, 2017
@WojciechRynczuk WojciechRynczuk self-assigned this May 31, 2017
@WojciechRynczuk
Copy link
Owner Author

The solution has been tested and it works properly for different EOLs for Windows and Linux. I decided not to indicate in the user manual any specific EOL which is supported as both of them are OK now.
A test is missing. As our github repository is stored in the Linux format one would have to prepare a script to manipulate input files on-the-fly.

WojciechRynczuk added a commit that referenced this issue Jun 6, 2017
WojciechRynczuk added a commit that referenced this issue Jun 6, 2017
@endrjux endrjux closed this as completed in 84da42d Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant