Merging infinite scrolling and improved CellViewController into main #2
Conversation
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat { | ||
| return 30 |
There was a problem hiding this comment.
this is not needed if you create the layout of the cells correctly. they can draw themselves.
There was a problem hiding this comment.
It works if i comment the code out, but it looks better with the function. Did you mean that i should make constraints for the cell instead of using this function?
| tmp.text = "Status: " + txt | ||
| return tmp | ||
| lazy var header: UIView = { | ||
| let c = UIView(frame: CGRect(x: 0, y: 0, width: view.frame.size.width, height: 450)) |
There was a problem hiding this comment.
use constraints instead of setting frame
| forCellReuseIdentifier: "character") | ||
| tableView.delegate = self | ||
| tableView.dataSource = self | ||
| tableView.separatorStyle = .none |
There was a problem hiding this comment.
all the tableView related things should be in the table view lazy initializer
|
|
||
| override func viewDidLayoutSubviews() { | ||
| super.viewDidLayoutSubviews() | ||
| tableView.frame = view.bounds |
There was a problem hiding this comment.
no need for setting frames, use constraints
| fatalError("init(coder:) has not been implemented") | ||
| } | ||
|
|
||
| init(person: CharacterModel){ |
There was a problem hiding this comment.
always put spaces between ")" and "{"
| let c = UIImageView()//must have this argument | ||
| c.sd_setImage(with: URL(string: self.person.image)) | ||
| c.snp.makeConstraints{ | ||
| make in |
There was a problem hiding this comment.
definition of properties in blocks should go one line above, after "{"
| lazy var image: UIImageView = { | ||
| let c = UIImageView()//must have this argument | ||
| c.sd_setImage(with: URL(string: self.person.image)) | ||
| c.snp.makeConstraints{ |
No description provided.