Extended Modding support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… internal mags This is basically a remerge of this branch: https://github.com/Kroporo/7DFPS/commits/ModdingImplementation It contains everything needed for the Rifle and Shotgun mods ported from earlier.
Also removes obsolete "UnityEngine" when using Random Also turns "1.0f" into "1f"
This allows people to fully choose the tiles they play on or guns to play with
Closed
|
This is a nitpick and can be fixed in a later pull request, but it prefer if the naming convention of variables is consistent throughout the project, i'm seeing some cases of snake case. I think the majority of the codebase uses under_score_deliniation. |
|
Nice work having the whitespace fix commit be separate, that really helps out with readability. Would have been nice if the two other changes mixed into the commit were two separate commits. Generall commits can't be too small. I'll tell you if you ever manage to achieve such a feat. Single line commits are amazing in my eyes, if they make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit in this pull request is the basis required to run the Shotgun and Rifle mods.
As this is basically a remerge of a previous branch, it is hard to split it up into nice smaller parts.
Part of #28