Skip to content

Commit

Permalink
Minor typo fix
Browse files Browse the repository at this point in the history
  • Loading branch information
Wolfteam committed Feb 8, 2022
1 parent 5c28be5 commit 2db1fc8
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 7 deletions.
9 changes: 3 additions & 6 deletions assets/db/characters.json
Expand Up @@ -1871,8 +1871,7 @@
718.4,
763.3,
808.2,
853.1,
0.0
853.1
]
},
{
Expand All @@ -1892,8 +1891,7 @@
12.0,
12.0,
12.0,
12.0,
0.0
12.0
]
},
{
Expand All @@ -1913,8 +1911,7 @@
40.0,
40.0,
40.0,
40.0,
0.0
40.0
]
}
]
Expand Down
2 changes: 1 addition & 1 deletion assets/i18n/en.json
Expand Up @@ -142,7 +142,7 @@
"key": "aloy",
"name": "Aloy",
"title": "Savior From Another World",
"description": "Formerly an outcast, now a hunter of unparalleled aptitude. Ready to do the right thing with her bow at any given time.",
"description": "Formerly an outcast, now a hunter of unparalleled skill. Ready to do the right thing at any time.",
"skills": [
{
"key": "s1",
Expand Down
11 changes: 11 additions & 0 deletions test/infrastructure/genshin_service_test.dart
Expand Up @@ -539,6 +539,17 @@ void main() {

final stats = service.getCharacterSkillStats(detail.skills[i].stats, skill.stats);
expect(stats, isNotEmpty);
switch (detail.skills[i].type) {
case CharacterSkillType.normalAttack:
case CharacterSkillType.elementalSkill:
case CharacterSkillType.elementalBurst:
expect(stats.length, 15);
break;
case CharacterSkillType.others:
break;
default:
throw Exception('Skill is not mapped');
}
final hasPendingParam = stats.expand((el) => el.descriptions).any((el) => el.contains('param'));
expect(hasPendingParam, equals(false));
}
Expand Down

0 comments on commit 2db1fc8

Please sign in to comment.