Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit inventory by longpress #112

Merged
merged 1 commit into from Sep 19, 2021
Merged

Edit inventory by longpress #112

merged 1 commit into from Sep 19, 2021

Conversation

Quintasan
Copy link
Contributor

No description provided.

@Quintasan Quintasan marked this pull request as draft September 7, 2021 00:39
@Quintasan Quintasan marked this pull request as ready for review September 9, 2021 12:02
@Quintasan Quintasan marked this pull request as draft September 9, 2021 12:03
@Wolfteam
Copy link
Owner

Also, @Quintasan make sure to update your branch, since this one is using the old GenshinDb name

@Quintasan
Copy link
Contributor Author

@Wolfteam done, let me know what do you think

Copy link
Owner

@Wolfteam Wolfteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@Wolfteam Wolfteam marked this pull request as ready for review September 18, 2021 01:44
* Show quantity dialog when long pressing the icon
* Reload the page after updating the inventory
@Quintasan
Copy link
Contributor Author

@Wolfteam done, should be okay now.

@Wolfteam
Copy link
Owner

LGTM!

@Wolfteam Wolfteam merged commit 62a42e5 into Wolfteam:main Sep 19, 2021
@Quintasan Quintasan changed the title WIP: Edit inventory by longpress Edit inventory by longpress Sep 19, 2021
@Quintasan Quintasan deleted the edit-inventory-by-longpress branch September 19, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants