Fix GUI Item Input Buttons deleting stacks on certain interactions #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Spigot has no API to get the affected slots of the action we need to figure it out manually. In order to keep track of the slots that need to be cleared and updated it uses a weak map, to collect the stack amounts. This will require an update for WolfyUtils too to work properly, as currently WU executes all the Item Input Buttons instead of just the affected ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the next WolfyUtils 4.16.12-beta.2 to properly fix the issue
This keeps track of Item Input Button slots in custom GUIs that are actually updated and only updates those. So non-interacted slots are kept as is and stacks are not removed.