Paper Plugin Implementation #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problems: * The Bukkit registration of commands doesn't seem to work with the new `paper-plugin.yml` * The new `paper-plugin.yml` is required to fix loading issues.
* Because this is not supported by paper!
* That is basically everything, but might be more separated in the future. * Register Commands dynamically, so they work with the `paper-plugin.yml` in place. * Removed WolfyCoreBukkit.getInstance, as that would interfere with WolfyCorePaper. (Use WolfyUtilCore.getInstance instead!) * Replaced WolfyCoreBukkit usages with WolfyUtilCore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
paper-plugin.ymlto specify a separate entry point for the plugin, and to fix load order issues, where CustomCrafting bootstrap happened before WolfyUtils, even with the depend options.Some changes were necessary (including breaking changes!):
paper-plugin.ymlnor in theplugin.yml. They are directly registered into the internal command map using reflections.