Improved StackReference Serialization #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Both formats are still supported * One format defines the parser and original stack * The other format defines the identifier and does not require parsing * New StackReferences are serialized using the latter format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StackReferences previously serialized the original stack, because it made it possible to change the parser afterwards. However that made it almost impossible to edit items from config.
This PR changes it so that StackIdentifiers can be serialized too so that the parsed information can be stored in the config and can easily be edited.
However, it has one downside. Once the recipe has been saved, the original stack you put into the slot is lost.
It now only exists in the form it was saved in, like the bukkit format, or another plugin item id.
When loaded back into the GUI that item will be the new "original item".