Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the use of <a> for .contentItemLink #3189

Closed
dtdesign opened this issue Mar 19, 2020 · 0 comments
Closed

Deprecate the use of <a> for .contentItemLink #3189

dtdesign opened this issue Mar 19, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@dtdesign
Copy link
Member

dtdesign commented Mar 19, 2020

The new .contentItemList was introduced as a generic implementation for content pieces that rely on teaser images. However, the DOM is somewhat flawed by expecting a link to wrap around the whole content section, which easily collides with certain content elments.

<a href="" class="contentItemLink">
  <!-- content -->
</a>

Should be changed into:

<div class="contentItemLink">
  <!-- content -->
  <a href="" class="contentItemLinkShadow"></a>
</div>

The CSS remains unaffected, causing no visual change if the old DOM is continued to be used, preserving compatibility with existing implementations.

We also need to deprecate the changes related to the removal of links in the message parsers. They tend to be unreliable and require way more changes than anticipated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant