Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra check that the user also has the right to upload attachment when editing a user #5945

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Cyperghost
Copy link
Contributor

See https://www.woltlab.com/community/thread/306725-fehler-bei-dateianhang-hochladen-in-signatur-und-konversation/

If an administrator is currently editing the signature of himself or another user, the tab for attachments is displayed. This is also the case if the right to upload attachments in the signature has been withdrawn from all user groups.

@Cyperghost Cyperghost requested a review from dtdesign June 17, 2024 10:15
@dtdesign
Copy link
Member

@Cyperghost Please validate that this does not cause issues when there already is an uploaded attachment, but the current user lacks the permission.

@Cyperghost
Copy link
Contributor Author

@Cyperghost Please validate that this does not cause issues when there already is an uploaded attachment, but the current user lacks the permission.

The attachment BB code is still displayed as a plain BB code. When saving, the reference is not removed from the database (wcf1_attachment.objectID). And it is displayed correctly in a post and in the preview.

@Cyperghost Cyperghost merged commit 1a7b26b into 6.0 Jun 17, 2024
9 checks passed
@Cyperghost Cyperghost deleted the bugfix/signature-attachment branch June 17, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants