New upload form field #5951
Merged
New upload form field #5951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check whether only images can be uploaded
register the language phrase `wcf.global.button.replace`
…allows the call `....click()` in the case of a `click` event.
Add image viewer support
dtdesign
reviewed
Jun 29, 2024
There was a problem hiding this comment.
A good start, but I would like to see the logic between attachments and the upload form field to be deduplicated. Do not use inheritance, but instead check if you can provide some general purpose functions that offload the work. Especially the DOM and upload progress are pretty much set in stone anyway and can easily be handled by a common function.
…e file upload and also `undefined` if no file is uploaded
… for `WoltlabCoreFileElement`.
Remove unnecessary comments
…on and doesn't insert it
…s clicked, to ignore the upload limit
Use a Promise to recognize the beginning of the upload to replace the context
dtdesign
requested changes
Jul 3, 2024
ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/event/listener/PreloadPhrasesCollectingListener.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
…Component/File/Helper`
dtdesign
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new upload form field with the new upload pipeline (#5668)