Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement--Script deployment support. Issue 926 #1004

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

kwekmaster
Copy link
Contributor

Addresses #926

  • Specification discussion was done earlier thru discord and can be ref'd if needed.
  • Supports all present and future scripting elements--assuming they are deployed under the game directory.
  • The sample testbed I used contain CET, redscript, and red4ext dlls for deployment.

Implemented

Assumptions for the preliminary approach: the user is responsible for structuring their scripts to match the target deployment directory structure.

  • The ability to deploy scripting elements user puts under resource into packed. Please see the testbed below for a sample structure.
  • Simple as-is copying, skipping the special yaml and xl files.

Notes
Hot deployment seems to follow a separate path and is not touched by this PR.

Testing Done

  • Using everything in the test bed below
  • With only yaml/xl files
  • With blank resources
  • Both as regular and REDmod

Testing meets the requirements.

Test Bed
Tests are done the following resources structure. .xl and .yaml files are added thru clicking (+)New File
image

Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@rfuzzo rfuzzo merged commit 8d92da2 into WolvenKit:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants