-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TweakXL YAML Editing and Export From TweakBrowserViewModel #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow "yaml" or "yml" extension for TXL - IsDirty for RDTTextViewModel - Combine OnSave writers
- is there a better way to list custom highlights?
This was
linked to
issues
Nov 11, 2022
Closed
rfuzzo
reviewed
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you run a code format over it? Are you using VS22 ?
Yes, I'm on VS22. I ran a cleanup across my files that cleaned up a few things |
rfuzzo
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of #922. This is a very rough implementation for initial support to generate TweakXL YAML files. This draft is to open discussion on implementation of features and usability of the current method.
Implemented:
TweakBrowserViewModel
Records ViewTweakBrowserViewModel
Records ViewNot Yet Implemented:
ChunkViewModel
forITweakXLItem
!append
and related tagsHow To Use:
a. Right-click and export from left-hand list (or)
b. Right-click an item in the right-hand TreeView and select "TweakXL -> Override Value"
Topics of Discussion:
TweakBrowserViewModel
(e.g. Step 3 above)ITweakXLItem
is structured