Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean all button--issue 1022. #1024

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

kwekmaster
Copy link
Contributor

@kwekmaster kwekmaster commented Dec 1, 2022

Thought this would be a simple UI addition, but it turns out not so:

Prior to this proposed change, the only way for the user to cleanup changes/removals/renames to "other" (e.g. r6/scripts/myscript.reds => r6/scripts/thecorrectnameformyscript.reds) already-packed files under resources is to manually delete them from the packed directory themselves.

I also added LaunchProfile entry and missing code path to Cleanup() to completely clean as an option. This allows it to clean misc items added or removed in resources dir, such as scripts.

Implemented and Added:

  • The Clean All button
    image

  • Added LaunchProfile options to do so.
    image

  • Added optional code path to Cleanup() to handle the rest of the resources/ dir not covered by it. Options are done thru LaunchProfiles. The user now can click Clean All or integrate it in their profile.

Testing:

  • Ensure Clean All does it's purpose, without any UI desync or oddness observed using the current removal method.
  • Ensure default behavior persists with the LaunchProfile option unchecked
  • Ensure intended behavior works with the LaunchProfile option checked
  • Integration with Install to Game: good integration. It also removes the logged files not found in the current packed/ directory.

…ode path to Cleanup() to completely clean, so it can also clean misc items added or removed in resources dir, such as scripts.
@kwekmaster kwekmaster linked an issue Dec 1, 2022 that may be closed by this pull request
@kwekmaster
Copy link
Contributor Author

Since I am currently traveling, I will have sporadic internet access

However, when I do, I shall address any concerns you may have and make any changes necessary.

Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I would even consider making cleanAll default in the future

@rfuzzo rfuzzo merged commit 76e48e6 into WolvenKit:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Add a "Clean" Button under build
2 participants