Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Garment Support for Custom Garments #1110

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Include Garment Support for Custom Garments #1110

merged 4 commits into from
Jan 24, 2023

Conversation

engres01
Copy link
Contributor

Include Garment Support for Custom Garments

Implemented:

  • Write to custom accessors in glb when exporting garment mesh
  • Write to Garment Support parameters when importing mesh with garment support data

@engres01
Write to Garment Support accessors when exporting garment mesh; write…
7017b68 
… to Garment Support parameters when importing mesh
rfuzzo
rfuzzo requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just Somme code style things so that the compiler is happy

WolvenKit.Modkit/RED4/Tools/MeshImportTools.cs Outdated Show resolved Hide resolved
WolvenKit.Modkit/RED4/Tools/MeshImportTools.cs Outdated Show resolved Hide resolved
WolvenKit.Modkit/RED4/Tools/MeshImportTools.cs Outdated Show resolved Hide resolved
WolvenKit.Modkit/RED4/Tools/MeshImportTools.cs Outdated Show resolved Hide resolved
@rfuzzo
Copy link
Member

rfuzzo commented Jan 23, 2023

I also don't know if this is fine wrt the blender plugin. Someone else would need to check this please. 🚀

rfuzzo
rfuzzo approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks good to me

@rfuzzo rfuzzo merged commit ec3656d into WolvenKit:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfuzzo rfuzzo rfuzzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@engres01 @rfuzzo