Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1114 - allow non 1:1 mlmasks. #1115

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

kwekmaster
Copy link
Contributor

Allow non 1:1 mlmasks to be imported thru WKit

Fixed:

  • removed code based on the incorrect assumption that all mlmasks are 1:1. It is not.
  • since the original code assumes that it is 1:1, need to also change the logic to determine power-of-two ness of the dimensions

Tested:

  • Maintained previous behavior for 1:1 mlmasks
  • Works with non 1:1 mlmasks
  • Enforcement of the power of two constraint

@kwekmaster kwekmaster linked an issue Jan 26, 2023 that may be closed by this pull request
Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rfuzzo rfuzzo merged commit 0211898 into WolvenKit:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: mlmasks that are not 1:1 in dimensions are blocked from import
2 participants