Mesh preview robustness #1141
Merged
Mesh preview robustness #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfuzzo
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mesh preview robustness
(Hopefully) Changed:
Clicking the "Generate materials for appearance" button will now recreate the materials. This was previously done only once (abort condition: rendered), and the user would be required to re-open the file if they changed anything.
Fixed: Exception breaking mesh preview
If more materialEntries than material definitions are present, there would be exceptions, and the mesh preview would break.
New behaviour: it will now stop parsing when it has reached the end of the list. Appearances with missing materials won't be listed. (Potentially it might be better to assign a default material? Maybe screaming pink with "UNDEFINED" on it? I don't know how, though.)
Will create a follow-up ticket.