Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use naudio implementation from naudio github #1147

Merged
merged 1 commit into from
Feb 8, 2023
Merged

use naudio implementation from naudio github #1147

merged 1 commit into from
Feb 8, 2023

Conversation

rfuzzo
Copy link
Member

@rfuzzo rfuzzo commented Feb 8, 2023

use naudio implementation from naudio github

Implemented:

  • proper audio implementation from scratch using Naudio samples
  • three different waveform visualizers

Fixed:

  • fixed various audio player issues
  • proper mvvm implementation

seberoth
seberoth approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@seberoth seberoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rfuzzo rfuzzo merged commit 459548b into main Feb 8, 2023
@rfuzzo rfuzzo deleted the fix/naudio branch February 8, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberoth seberoth seberoth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rfuzzo @seberoth