-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ResourcePath type #1156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into resourcepath
- add ResourcePathPool to HashService - rename CNameWrapper to ReourcePathWrapper - add display setting for ResourcePath hashes
… files - fix typo for ResourcePathWrapper - update Properties View to better reflect how numbered files in the root directory are hashed
seberoth
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1062
Closes #1130
Implemented:
ResourcePath
type rather thanCName
to ensure files are properly hashed before loading into the gameRedRefEditor
is now based onResourcePath
enabling hashes written to CR2W files to be properly sanitizedChunkViewModel
will now display hashes and guessed extensions for files without a resolved pathChunkViewModel
will now add hashes forraRef
s that have a DepotPath and a hash, but are not loaded into theHashService
as user hashes. This does a few additional things:ChunkViewModel
will now place files in the project with their resolved paths even if they didn't previously have a hash inHashService
Open in new tab
inChunkViewModel
will now open the tab with the resolved name and/or extension (rather than1234.....bin
)Fixed:
HashService
upon application startNotes:
ChunkViewModel
will only add hashes if the tree view is expanded to araRef
, it doesn't currently scan the entire file upon openingraRef
that is displaying only the hash, adding the file will still only use the hash and guessed file extension and be placed in the root directory. It might be possible to scan for such files and rename accordingly at a later date