Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garment Support fixes #1214

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Garment Support fixes #1214

merged 1 commit into from
Mar 11, 2023

Conversation

engres01
Copy link
Contributor

Garment Support attribute check and type fix

Implemented:

  • Removed unnecessary check for color attribute before writing to garment support parameters, since importing garment support is currently driven by a checkbox in import settings

Fixed:

  • Fixed an incorrect integer type being written to a parameter in the off chance that the cap color attribute has a value

@engres01
Fixed wrong integer type being written to buffer, removed unnecessary…
8af55e5 
… check for importing garment support since it's currently being driven by a checkbox
manavortex
manavortex reviewed Mar 11, 2023
View reviewed changes
Copy link
Contributor

@manavortex manavortex left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have no idea what it does, but this won't break anything… I think.
(Unfortunately, I can't approve this… probably for the best…)

seberoth
seberoth approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@seberoth seberoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mana said it all...

@seberoth seberoth merged commit 74938f2 into WolvenKit:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manavortex manavortex manavortex left review comments

@seberoth seberoth seberoth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@engres01 @seberoth @manavortex