Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DockingManager improvements #1220

Merged
merged 6 commits into from
Mar 15, 2023
Merged

DockingManager improvements #1220

merged 6 commits into from
Mar 15, 2023

Conversation

seberoth
Copy link
Contributor

DockingManager improvements

Fixed:

  • Saving layout to appdata on close even if a project is loaded
  • Import/Export window state not saving

Removed custom DockPanes.txt and use SyncFusions state file for loading

@seberoth
refactor: Removed custom DockPanes.txt
1b3e03a 
fix: Saving layout to appdata on close even if a project is loaded
fix: Import/Export window state not saving
manavortex
manavortex reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@manavortex manavortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working! \o/ (I didn't check the code, for that matter, just the functionality)

@manavortex
Copy link
Contributor

Before the asset browser is initialized, WKit displays this:
image
It then turns into this:
image

It's going to confuse the fuck out of users :/
Asset browser doesn't initialize without me clicking the load button.

@seberoth seberoth marked this pull request as draft March 13, 2023 18:42
@seberoth
Revert "fix: Load default views on startup"
904d986 
This reverts commit 65f6dad.
@seberoth
fix: Fix AB loading, better approach
b1b5dd3 
feature: AB without project, permit file operations...
@seberoth seberoth marked this pull request as ready for review March 13, 2023 20:32
@rfuzzo
Copy link
Member

rfuzzo commented Mar 14, 2023

is this ready to merge?

@seberoth seberoth marked this pull request as draft March 14, 2023 06:24
@seberoth
Copy link
Contributor Author

50/50, so no^^

@seberoth seberoth marked this pull request as ready for review March 14, 2023 20:29
@rfuzzo rfuzzo merged commit 8cf7f5b into main Mar 15, 2023
@seberoth seberoth deleted the fix/DockingManager branch March 23, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manavortex manavortex manavortex left review comments

@rfuzzo rfuzzo rfuzzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seberoth @manavortex @rfuzzo