fix: Morphtarget Export and Import #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertex diff mappings are stored contiguously in the RE4 buffer, 2 bytes per. Because the mapping count is for some reason stored as half the actual count, it needs to be padded by an extra empty 2byte when the diff count is odd. Tried to make the logic a bit more explicitly laid out, too.
Bounds are calculated from maximum morphed or unmorphed dimensions, and passed along for not only the morph but also the baseblob. The quantization needs to have a scale wider than the possible values in its range including the morphs, so that the quantized value is always `1.0 >= q <= -1.0`.
Much of this is restructuring the logic and making it more explicit, but the bookkeeping and data buffer construction now produce 1:1 results compared against vanilla. Should support: 1. Vanilla reimports with unchanged morphtargets 2. Modified vanilla 3. Custom morphtargets (although the *game* doesn't do anything with these) BREAKING CHANGE: Relies on the new, fixed export logic. Will fail at least on some previously exported (and thus broken) morphtargets. Might be able to add fixes for some cases, but needs to be flagged to users.
|
I still need to tidy some things up a bit but I think the logic is there and uncluttered enough to review. |
In some cases it looks like the diff count is recorded incorrectly for Vanilla morphs. The data buffers are set up as though there's 0 diffs so using the mapping count is correct.
This and the one in mappings were hiding the incorrect calculations earlier. We want to fail if for some reason the calculation is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Export: produces correct data so that it actually can be imported correctly*
Import: produces working morphtargets for vanilla/modified/custom morphs**
Breaking
Previously exported and/or imported morphtargets are likely to have at least some issues. Users may need to re-export and port their work on top of that.
More
The commits are kinda split up and the commit messages worth reading but, YMMV, it may be easier to actually review the code by reading the entire file instead of a diff.
*,** I mean, like, probably? I haven't tested that extensively.
Evidence for the defense: sculpted neck on a head morph (with still-working customization & expressions)
