Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Calculate Morphtarget Bounds Cumulatively on Import #1279

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

effs
Copy link
Contributor

@effs effs commented Apr 18, 2023

The influences can be combined. Whether they're treated as cumulative or mutually exclusive is completely external semantics. We must assume cumulative in order to create a big enough bounding box and quantization space.

The influences can be combined. Whether they're treated as cumulative or
mutually exclusive is completely external semantics. We must assume cumulative.
@effs effs requested a review from seberoth April 18, 2023 09:50
@effs
Copy link
Contributor Author

effs commented Apr 18, 2023

It's quite possible I'm overlooking something here (since I already overlooked this) so more eyes would be nice.

Copy link
Contributor

@seberoth seberoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seberoth seberoth merged commit 34a4bac into main Apr 20, 2023
2 checks passed
@effs effs deleted the fix/1278/morphtarget-cumulative-deltas branch April 21, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants