Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1289, Possibly null reference #1290

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Fix #1289, Possibly null reference #1290

merged 1 commit into from
Apr 22, 2023

Conversation

paulober
Copy link
Contributor

Possibly null reference

Implemented:

  • ? to avoid possibly null reference
  • Naming scheme for some variables
  • Added missing param tag in XML comment

Fixed:

@paulober
Fix WolvenKit#1289, Possibly null reference
f4c6f5e 
fix: Possibly null reference
fix: Naming scheme for some variables
fix: Added missing param tag in XML comment
@paulober paulober force-pushed the fix-1289-possibly-null-reference branch from 7a47f43 to f4c6f5e Compare April 22, 2023 11:36
seberoth
seberoth approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@seberoth seberoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seberoth seberoth merged commit 8ba87fd into WolvenKit:main Apr 22, 2023
2 checks passed
@paulober paulober deleted the fix-1289-possibly-null-reference branch April 22, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberoth seberoth seberoth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dereference of a possibly null reference
2 participants
@paulober @seberoth