Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved scripting #1306

Merged
merged 18 commits into from
Jun 15, 2023
Merged

Improved scripting #1306

merged 18 commits into from
Jun 15, 2023

Conversation

seberoth
Copy link
Contributor

Improved scripting

Implemented:

  • New scripting Manager
    • Run scripts directly
    • Seperated general/hook/ui scripts
    • Ability to enable/disable scripts
    • Ability to provide metadata infos via script files
  • Added hooks for import/export
  • Added possibility to control documents (tabs) via scripting

Fixed:

  • UI scripts couldn't access other scripts

Additional changes:

  • Replaced onSave files with hook
  • Improved file exporting via script

@seberoth
feature: Added new Script Manager
8951989
@seberoth
Copy system files on open
703bb7f
@seberoth
fix: Scripting imports loading
bdc8c20
@seberoth
feature: Added version string to wscripts
4c4fa98
@seberoth
More info
a0df217
@seberoth
Merge remote-tracking branch 'origin/main' into feature/new-script-ma…
cf5b48c 
…nager
@seberoth
Merge remote-tracking branch 'origin/main' into feature/new-script-ma…
fec1cd4 
…nager
@seberoth
feature: Replaced onSave file with hook_global
9f8b584
@seberoth
feature: Allow opening/closing documents
db5e707 
fix: Make ui_ scripts js modules, too
@seberoth
Removed unneeded async/await
e267d4a
@seberoth
Prepare more hooks
b8c203e
@seberoth
Some cleanup and renaming
5853f38
@seberoth
Added default settings to script export
948e965
@seberoth
Merge remote-tracking branch 'origin/main' into feature/new-script-ma…
0e8d9e8 
…nager
@seberoth
feature: Add pre import hook (executed before import)
19a88f9 
fix: Some problems
@seberoth
fix: Scripting manager buttons not working
f5b53dd
@seberoth
Updated metadata
fcebcc8
@seberoth seberoth requested a review from rfuzzo June 14, 2023 13:24
rfuzzo
rfuzzo previously approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually improved code review

@seberoth seberoth dismissed rfuzzo’s stale review June 14, 2023 13:36

The merge-base changed after approval.

rfuzzo
rfuzzo approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually approving again after update

@seberoth seberoth merged commit 657497c into main Jun 15, 2023
2 checks passed
@seberoth seberoth deleted the feature/new-script-manager branch June 15, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfuzzo rfuzzo rfuzzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seberoth @rfuzzo