Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/json fixes filevalidation #1320

Merged
merged 5 commits into from
Jul 2, 2023
Merged

Fix/json fixes filevalidation #1320

merged 5 commits into from
Jul 2, 2023

Conversation

manavortex
Copy link
Contributor

More robustness and an additional check in the .app file

More file validation

Fixed:

  • using a better regex to check for placeholder appearances and entries
  • changed Logger's object stringification from JSON.stringify to TypeHelper.JsonStringify to prevent exceptions
  • Added try/catch with user-readable error msg to file validation hook

@seberoth seberoth merged commit 96453d7 into fix/json-fixes Jul 2, 2023
@seberoth seberoth deleted the fix/json-fixes-filevalidation branch July 2, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manavortex @seberoth