FIX: Provide Root Explicitly for Single-Joint Rig Export #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SharpGLTF's ancestor finder assumes a single node is the root node https://github.com/vpenades/SharpGLTF/blob/b23b5ce225637f38a00be67f4641c991ed36435d/src/SharpGLTF.Core/Schema2/gltf.Skin.cs#L238
|
Should probably test this some :thinkies: and I'm not really sure it's a great solution.. but there's a lot of cruft on this path so it may be better left cleaned up in the grand unified exporter theory. |
rfuzzo
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
SharpGLTF's ancestor finder assumes a single node is the root node, so it calculates the inverse bind matrix incorrectly.
https://github.com/vpenades/SharpGLTF/blob/b23b5ce225637f38a00be67f4641c991ed36435d/src/SharpGLTF.Core/Schema2/gltf.Skin.cs#L238