Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: .anims Export and Import #1426

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fix: .anims Export and Import #1426

merged 2 commits into from
Nov 13, 2023

Conversation

effs
Copy link
Contributor

@effs effs commented Nov 11, 2023

Summary

Basic support for all motion animation export/import. There's very likely a lot of work left to support all cases.

  • Fixed data decoding/encoding of .anims buffers
  • Added decoding/encoding for track information from the buffer
  • Added track and other non-buffer animation data to GLTF encoded into the extra field (there isn't really any way to represent it in the standard animations format.)

Testing

Only manually validated on a limited set of .anims

BREAKING

Previously exported .anims contain incorrect/incomplete data. Need to see about a migration path, unless it's ~trivial to fix it on the Blender side and/or using new buffer logic

Known Issues

  • All .anims data isn't exported yet
  • Root Motion not reimported
  • Only existing animations can be edited

Additional work tracked in #1425

Dependencies

Probably needs work in the Blender plugin just to work, and definitely to use new capabilities.

Fixed

Closes #1403

Slightly better JSON support.
BREAKING CHANGE: previously exported .anims need to be migrated. TBD.
@effs effs added the animation label Nov 11, 2023
@rfuzzo rfuzzo merged commit 324deb6 into main Nov 13, 2023
2 checks passed
@rfuzzo rfuzzo deleted the fix/1403/anims branch November 13, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vehicle .anim files corrupted when import
2 participants