Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anims: Experimental SIMD Animation Support & Blender Fixes #1448

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

effs
Copy link
Contributor

@effs effs commented Nov 25, 2023

NB: might still add default skip on import for the problematic SIMD animations

SIMD (Experimental)

SIMD animations are heavyweight and detailed. There aren't that many of them, but they tend to be the showy ones. The buffer format is distinctly optimized for SIMD semantics (obvs.)

Blender Enhancements

  • Additive animations are exported with local transform included so they show up more manageable in Blender until there's support for loose anims on that side. Import strips the local again.
  • Misc. fixes

GLTF

  • Extra data schema V3 improves (?) V2
  • Migration mechanism for versions
  • Migration from V2 to V3 on import

Internals

  • Create new data structures instead of replacing them on import. This should also enable partial animset replacements (with non-updated either kept or deleted) and adding new animations.

@effs effs added bug enhancement animation gltf GLTF format or export/import labels Nov 25, 2023
@effs effs force-pushed the fix/1425/anims-simd-export-and-blender-compat branch from d7ad2a7 to 445abe0 Compare November 25, 2023 15:34
@kmirea
Copy link

kmirea commented Nov 25, 2023

Can i comment here ? :P

I was poking at one of the additive weapon anims, noticed that a particular sequence, was followed by another two of same name (affixed with _0 and _1) respectively and same buffer length, is it possible these should be combined into one import. once i actually able to parse them and see transforms might have an answer,,but just a thought (for reference; pwa_procedural_weapon.anims => add_body_hit_270_upperbody, add_body_hit_270_upperbody_01, add_body_hit_270_upperbody_02)

@effs
Copy link
Contributor Author

effs commented Nov 25, 2023

is it possible these should be combined into one import

Couldn't say, they don't look obviously connected (but they can ofc be additive on top of one another.) Other kinds with number suffixes seem to be variants of the same base animation.

@effs effs requested a review from kainotoa November 25, 2023 16:12
@rfuzzo rfuzzo merged commit 079e379 into main Nov 27, 2023
2 checks passed
@rfuzzo rfuzzo deleted the fix/1425/anims-simd-export-and-blender-compat branch November 27, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animation bug enhancement gltf GLTF format or export/import
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants