Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text wrapping to String fields #1491

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

richard-kelly
Copy link
Contributor

Implemented:

  • turned on toggle to make string fields wrapped so that long pieces of text can be viewed in full when editing.

The use case for this feature is for when editing custom localization files in Wolvenkit. It's not easy to edit a large piece of text with only a small part of it showing at once. Editing the exported json files in a text editor can be difficult because of special characters like \u003CRich color=\u0022TooltipText.cyberwareDescriptionHighlightColor\u0022 style=\u0022Semi-Bold\u0022\u003EFury\u003C/\u003E state.

Here is an example before and after from onscreens_final.json:

Before:
no_wrap

After:
with_wrap

Testing:

  • I tested editing and saving a localization value, which worked.
  • Nothing visually looks wrong that I can see.
  • I'm not familiar enough with the code to know if there are any likely side effects from this. Does this only affect string fields in JsonResources?

Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good, thanks

@rfuzzo rfuzzo merged commit c9c9cbe into WolvenKit:main Dec 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants