fix: Morphtarget Meshes Can Also Include GarmentSupport #1510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
.morphtarget
s can include GarmentSupport data, i.e. they can (typically) shrink under clothing when GS is active.mesh
and.morphtarget
(it was already default on export)NB:
GarmentSupport
must be first shapekey/target and let's require that naming too.Usage
General GarmentSupport guide on the redmodding wiki
GarmentSupport
for each submesh that you want to deform for GS, typically shrinking the mesh a bit so that it doesn't clip with tighter fitsGarmentSupport
is the first shapekey (afterBasis
)_GARMENTSUPPORTWEIGHT
and_GARMENTSUPPORTCAP
attributes.mesh
, then the.morphtarget
just like usualDetes
Both morphtarget and GS data are encoded in glTF targets so we need to be careful which targets we use for which purposes.
Issues/TODO
The following tickets still have relevant open questions or fixup/cleanup, but this is probably safe enough to test as is.