Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Morphtarget Meshes Can Also Include GarmentSupport #1510

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

effs
Copy link
Contributor

@effs effs commented Jan 12, 2024

Implemented

  • .morphtargets can include GarmentSupport data, i.e. they can (typically) shrink under clothing when GS is active
  • GarmentSupport is checked by default for import for both .mesh and .morphtarget (it was already default on export)

NB: GarmentSupport must be first shapekey/target and let's require that naming too.

Usage

General GarmentSupport guide on the redmodding wiki

  1. In Blender, create a shapekey named GarmentSupport for each submesh that you want to deform for GS, typically shrinking the mesh a bit so that it doesn't clip with tighter fits
  2. Ensure GarmentSupport is the first shapekey (after Basis)
  3. Include _GARMENTSUPPORTWEIGHT and _GARMENTSUPPORTCAP attributes
  4. Blender-Export w/ the cp77 Blender plugin
  5. Import into wkit with the garment support option checked (should be by default), first the .mesh, then the .morphtarget just like usual

Detes

Both morphtarget and GS data are encoded in glTF targets so we need to be careful which targets we use for which purposes.

Issues/TODO

The following tickets still have relevant open questions or fixup/cleanup, but this is probably safe enough to test as is.

@effs effs linked an issue Jan 12, 2024 that may be closed by this pull request
@seberoth seberoth merged commit 8d47adf into main Jan 14, 2024
2 checks passed
@seberoth seberoth deleted the fix/1507/morphtangent-normal-garment branch January 14, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Morphtargets and GarmentSupport CAN Coexist if we Just Believe
2 participants