Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Override Mesh Name with Node Name when Importing for Compatibility #1520

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

effs
Copy link
Contributor

@effs effs commented Jan 18, 2024

To support older files without modders having to fix their mesh naming in Blender, new import option that forces using the node name (object name in Blender) instead of the actual mesh name.

Screenshot 2024-01-18 082336

There's a warning printed if the names don't match either way.

Screenshot 2024-01-18 083313

The problem as seen in Blender (modder has only changed the top-level object name, which doesn't automatically change the mesh data block name, resulting in the alphabetical submesh order probably being broken)
image

Breaking

  • Error if a mesh is referenced by multiple nodes, unless someone comes up with a valid use case (in which case the entire import logic needs to be reviewed.)

closes #1519

@effs effs added bug mesh gltf GLTF format or export/import labels Jan 18, 2024
Copy link
Contributor

@seberoth seberoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seberoth seberoth merged commit 39f85ff into main Jan 18, 2024
2 checks passed
@seberoth seberoth deleted the fix/1519/optional-mesh-name-override branch January 18, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gltf GLTF format or export/import mesh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: submesh order not preserved on import
2 participants