Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new type selector #1527

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Feature/new type selector #1527

merged 3 commits into from
Jan 23, 2024

Conversation

seberoth
Copy link
Contributor

Feature/new type selector

Implemented:

  • new type selector

new("HairParameters", "Reference to hp file", typeof(CResourceReference<CHairProfile>)),
new("MultilayerMask", "Reference to mlmask file", typeof(CResourceReference<Multilayer_Mask>)),
new("MultilayerSetup", "Reference to mlsetup file", typeof(CResourceReference<Multilayer_Setup>)),
new("Scalar", "", typeof(CFloat)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be "a decimal number". Also, maybe Integer is missing here? Or can we use Scalar interchangeably and the engine will cope?

Copy link
Contributor

@manavortex manavortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Cursory review and a manual text - it seems to work… no doubt someone will find edge cases)

@rfuzzo rfuzzo merged commit 633ebb0 into main Jan 23, 2024
2 checks passed
@rfuzzo rfuzzo deleted the feature/new_type_selector branch January 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants