Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inkWidget Improvements #1550

Merged
merged 10 commits into from
Feb 3, 2024
Merged

inkWidget Improvements #1550

merged 10 commits into from
Feb 3, 2024

Conversation

jackhumbert
Copy link
Contributor

@jackhumbert jackhumbert commented Feb 1, 2024

inkWidget Improvements

  • Allows custom dynamic classes inheriting from inkIWidgetController & inkWidgetLogicController
    • Class must exist in mod's redscripts or otherwise registered with the RTTI
    • Modifies Handle creation type selector to allow entering the custom class name (base type is dependent on the handle)
    • Adds context menu option for editing class name
    • Allows adding, removing, and renaming of properties (only inkWidgetReference types for the time being, but any should be supported) of dynamic classes
  • Allows editing of inkWidgetReference
    • Allows copy/pasting from/to regular Handle<inkWidget>
  • Adds a hook that copies inkWidgetLibraryItem.package to inkWidgetLibraryItem.packageData on saving .inkwidget files, and hides packageData from the UI
    • The only difference between package & packageData in the game is package is used for synchronous spawning, and packageData is (generally) used for asynchronous spawning (@psiberx, 2022)
    • inkWidget.backendData is often only found in packageData, and is not created upon copy - this doesn't seem to affect anything that I've seen

Misc Fixes

  • Fixes TweakXL context menu visibility in TreeView

Copy link
Contributor

@seberoth seberoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rfuzzo rfuzzo merged commit ef692a2 into main Feb 3, 2024
2 checks passed
@rfuzzo rfuzzo deleted the feature/inkwidget branch March 12, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants