Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1540 overwrite array/buffer with selection #1551

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

manavortex
Copy link
Contributor

overwrite array/buffer with selection

Implemented:

WolvenKit.App/ViewModels/Shell/ChunkViewModel.cs Outdated Show resolved Hide resolved
WolvenKit.App/ViewModels/Shell/ChunkViewModel.cs Outdated Show resolved Hide resolved
- Changed RedDocumentTabViewModel's CopiedChunks property to a getter - without this, it's flakey
- Moved context menu icon style definitions to global app.xaml
- Changed RedTreeView.xaml to use global styles for icons
- Added new flag for visibility checking
Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually approved PR

@manavortex manavortex dismissed seberoth’s stale review February 3, 2024 17:10

I implemented the changes in a later version, but somehow github doesn't catch on >.<

@manavortex manavortex merged commit f0bdd2a into main Feb 3, 2024
2 checks passed
@rfuzzo rfuzzo deleted the 1540-overwrite-array-buffer branch February 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants