Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesh material: more fallback upon export failures, better logging #1581

Merged
merged 2 commits into from
Feb 28, 2024
Merged

mesh material: more fallback upon export failures, better logging #1581

merged 2 commits into from
Feb 28, 2024

Conversation

manavortex
Copy link
Contributor

I hope this didn't break the singleton

seberoth
seberoth requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@seberoth seberoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls don't do that. Pass it down like everywhere else.
Would create a second instance. Also won't work with CLI

@manavortex
Copy link
Contributor Author

Pls don't do that. Pass it down like everywhere else. Would create a second instance. Also won't work with CLI

Alright, that was what I didn't know :) How do I pass it down? I followed the chain two or three hops, and didn't find any loggers

@seberoth
Copy link
Contributor

ModTools has _loggerService
Add it to MaterialExtractor (also as _loggerService) and pass it into its constructor

seberoth
seberoth approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@seberoth seberoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manavortex manavortex merged commit 076047c into main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberoth seberoth seberoth approved these changes

@rfuzzo rfuzzo Awaiting requested review from rfuzzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manavortex @seberoth