Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CR2W Improvements #969

Merged
merged 18 commits into from
Oct 23, 2022
Merged

CR2W Improvements #969

merged 18 commits into from
Oct 23, 2022

Conversation

seberoth
Copy link
Contributor

@seberoth seberoth commented Oct 19, 2022 •
edited

CR2W Improvements

Implemented:

  • Added options to display/edit hashes as hex values
  • Changed file saving to temporary file, so that the file doesn't get corrupted on error
  • Changed all pseudo value types to real value types
  • Reworked Red4Reader for better DynamicClass support

Additional notes:

  • Empty CName / Resource path will now get displayed as "None". JSON export is unaffected.

@seberoth
- Reworked Red4Reader
769469c 
- Changed IRedImport DepotPath from string to CName
@seberoth
Converted all pseudo valueTypes to real valuesTypes
60ef4c7
@seberoth
- Updated CString
d4bbbdc 
- Improved CName, CString and NodeRef editors
@seberoth
- Fixed RefEditor
72af407
@seberoth
- Improved RedRefEditor
e4457e9 
- Show flags for RedRefs
- Small layout tweak
@seberoth
Merge remote-tracking branch 'origin/main' into feature/cr2w-improvem…
eeafe45 
…ents
@seberoth
Added options to show hashes as hex value
ad86dd5
@seberoth
Fixed bug while writing IRedRefs
568b183
@seberoth
Better error handling on save
96f2f4f
@seberoth
Some fixes
0778670
@seberoth
- Added error handling for non resolveable types
3206d1a 
- Small fix to PersistencySystem2 reader
@seberoth
Added ErrorHandler to CyberpunkSaveReader
28393e5
@seberoth
- Added option to add custom types to Red4Reader
e9d0875 
- Some cleanup
@seberoth
Merge remote-tracking branch 'origin/main' into feature/cr2w-improvem…
3cf2326 
…ents
@seberoth
Fixed merge issue
9562dfa
@seberoth
Fixed rRef/raRef json import
5464e5e
@seberoth seberoth marked this pull request as draft October 19, 2022 08:14
@seberoth
- Changed CName JSON export back to 0 instead of "None"
da02457
@seberoth
- Changed CString default value from "\0" to string.Empty
f4345bd 
- Fixed CkeyValuePair creation to use CName.Empty instead of ""
- Fixed CString editor not updating properly
@seberoth seberoth requested a review from rfuzzo October 19, 2022 09:18
@seberoth seberoth marked this pull request as ready for review October 19, 2022 09:19
@seberoth seberoth merged commit 8430d6c into main Oct 23, 2022
@seberoth seberoth deleted the feature/cr2w-improvements branch October 23, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfuzzo rfuzzo Awaiting requested review from rfuzzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@seberoth