Issue 993--Add a textbox to the settings to add ignored extensions #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Issue 993 by adding an "ignored extensions" Textbox to settings.
Implemented:
@rfuzzo 's suggestion: to use a textbox in WolvenKit Settings that delegates all listed extensions to the default System Editor.
How it looks in the Settings Dialog:
Notes
Delimiter is currently set to pipe/vertical bar "|". Comparisons are all lowercase, following existing code. I did a simple Trim() for a bit more robust user entry handling.
Testing done:
Limited functional testing w.r.t the change, such as entering multiple extensions and seeing how the double clicking responds. Results satisfies the requirements.