Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL: Discord Issue--Notify and Log items that fail Import/Export. Total count bugfix #999

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

kwekmaster
Copy link
Contributor

@kwekmaster kwekmaster commented Nov 8, 2022

Discord Issue: Log/Notify users on items that fail Import/Export. Bonus: Total count bugfix.

Addresses the following issue:
(EDIT: correct discord link)
https://discord.com/channels/717692382849663036/1038844130341695538/1038844130341695538

The discord issue mentioned only import. Adding it to export is trivial and may provide useful.

Implemented:

  • Logged failed items when importing/exporting
  • Notify users of failed items when importing/exporting. Coalesced into one notification window only.

Bug Fixed:

  • Total count is not populated when executing Process All, specifically when Importing. Fix is simple and obvious.

Testing Done:
Tests are done on my personal project of 100 files. The following scenarios were successfully tested for both Import/Export:

  • All valid files
  • Several invalid files
  • Clicking Process Selected when there is nothing selected

Test results are satisfactory and meet and/or exceed the requirements.

@kwekmaster kwekmaster changed the title QOL: Notify and Log items that fail Import/Export. Total count bugfix QOL: Discord Issue--Notify and Log items that fail Import/Export. Total count bugfix Nov 8, 2022
Copy link
Member

@rfuzzo rfuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rfuzzo rfuzzo merged commit eb05e8c into WolvenKit:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants