Base Api methods are updated.

WondeTadesse · Nov 2, 2014 · 49b88cc · 49b88cc
1 parent 18ff166
commit 49b88cc
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 15 deletions.
diff --git a/WebAPICommonLibrary/PhysicianBaseContoller.cs b/WebAPICommonLibrary/PhysicianBaseContoller.cs
@@ -46,22 +46,20 @@ public virtual PhysicianBase GetPhysician(int id)
             }
         }
 
-        [HttpGet]
-        public virtual HttpResponseMessage ActivePhysicians()
+        [NonAction]
+        public virtual List<PhysicianBase> ActivePhysicians()
         {
             try
             {
-                var result = Physicians.Instance().Where(p => p.IsActive == true).ToList();
-                return result != null ? Request.CreateResponse(HttpStatusCode.OK, result) : Request.CreateResponse(HttpStatusCode.BadRequest);
+                return Physicians.Instance().Where(p => p.IsActive == true).ToList();
             }
             catch (Exception exception)
             {
-                return Request.CreateResponse(HttpStatusCode.InternalServerError,
-                     new Message() { Content = exception.Message });
+                throw exception;
             }
         }
 
-        [HttpPost]
+        [NonAction]
         public virtual HttpResponseMessage RemovePhysician(int id)
         {
             try
@@ -78,7 +76,7 @@ public virtual HttpResponseMessage RemovePhysician(int id)
             }
         }
 
-        [HttpPost]
+        [NonAction]
         public virtual HttpResponseMessage AddPhysician(PhysicianBase physician)
         {
             try

diff --git a/WebAPIDocumentationDemo/Controllers/PhysicianController.cs b/WebAPIDocumentationDemo/Controllers/PhysicianController.cs
@@ -46,7 +46,7 @@ public new HttpResponseMessage GetPhysicians()
         [WebAPIDocLib.ResponseType(typeof(PhysicianBase))]
         [WebAPIDocLib.RequestType(typeof(InternalPhysicianBase), "physician")]
         [HttpGet]
-        public HttpResponseMessage GetPhysician(InternalPhysicianBase physician)
+        public HttpResponseMessage GetPhysician([FromUri]InternalPhysicianBase physician)
         {
             // Try to get physician by ID or FirstName ....
             return Request.CreateResponse(HttpStatusCode.OK, base.GetPhysician(physician.ID), new MediaTypeHeaderValue("application/json"));
@@ -58,9 +58,9 @@ public HttpResponseMessage GetPhysician(InternalPhysicianBase physician)
         /// <returns>List of physicians</returns>
         [WebAPIDocLib.ResponseType(typeof(ExternalPhysician))]
         [HttpGet]
-        public override HttpResponseMessage ActivePhysicians()
+        public new HttpResponseMessage ActivePhysicians()
         {
-            return base.ActivePhysicians();
+            return Request.CreateResponse(HttpStatusCode.OK, base.ActivePhysicians(), new MediaTypeHeaderValue("application/json")); 
         }
 
         /// <summary>
@@ -70,7 +70,7 @@ public override HttpResponseMessage ActivePhysicians()
         /// <returns>Message object</returns>
         [WebAPIDocLib.ResponseType(typeof(PhysicianBase))]
         [HttpPost]
-        public override HttpResponseMessage RemovePhysician(int id)
+        public new HttpResponseMessage RemovePhysician([FromBody]int id)
         {
             return base.RemovePhysician(id);
         }

diff --git a/WebAPISecureSocketLayering/Controllers/PhysicianController.cs b/WebAPISecureSocketLayering/Controllers/PhysicianController.cs
@@ -50,10 +50,10 @@ public new  HttpResponseMessage GetPhysician(int id)
             }
         }
 
-        [HttpPost]
-        public override HttpResponseMessage ActivePhysicians()
+        [HttpGet]
+        public new HttpResponseMessage ActivePhysicians()
         {
-            return base.ActivePhysicians();
+            return Request.CreateResponse(HttpStatusCode.OK, base.ActivePhysicians(), new MediaTypeHeaderValue("application/json"));
         }
 
         [HttpGet]