feat: onChangeComplete event #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondermarin
requested changes
Jun 19, 2024
Wondermarin
requested changes
Jun 21, 2024
|
thank you @Wondermarin!! |
Wondermarin
approved these changes
Jun 27, 2024
Merged
|
Released in v7.2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is a very good library and it is a breeze to integrate it.
I've wanted to enhance it by adding a new optional event called
onChangeCompletethat its goal to be fired right after the user stops interacting with any element, which is useful for the ones that needs to perform a side-effect action when that happens.Use case example: You want to save the user's chosen color either remotely thru an API or locally in the storage. By hooking up this action on
onChange, you will have a lot of actions happening as the user might be exploring the color picker up until the point it stops the interaction.Description of Change
A new prop is added to Interactive component and therefore propagated into Alpha, Saturation and Hue ones. I've also added the change into Fields by leveraging the onBlur input event.
In Interactive component I've chosen to modify the original
moveevent by adding a boolean at the end by I'm not completely sure that is the best option to achieve the goal. Happy to apply any modifications you may see necessary.Finally, added the README.md changes: one new example using the new event and add a new entry to the prop table.