Skip to content
This repository has been archived by the owner on Jan 28, 2023. It is now read-only.

[Dev-Nightly] Rest of config is swiping after /woo register #60

Closed
HappyHarm opened this issue Jan 19, 2016 · 33 comments
Closed

[Dev-Nightly] Rest of config is swiping after /woo register #60

HappyHarm opened this issue Jan 19, 2016 · 33 comments

Comments

@HappyHarm
Copy link
Contributor

When you use /woo register to key the key for the first time it saves the key to the config but swipes the rest of the config http://prntscr.com/9s20s2

@ethsmith
Copy link

I looked at the code and I know exactly what's do it.

@ethsmith
Copy link

I will try to get on a PC in 15 if I can and fix it

@ethsmith
Copy link

I will have it fixed today after i'm out of class.

@HappyHarm
Copy link
Contributor Author

See that you did some commits in the dev-nightly with the config? Is the issue solved?

@ethsmith
Copy link

@HappyHarm should be I gotta jar download in releases section.

@HappyHarm
Copy link
Contributor Author

Need to compile it with java 7 for myself. Will do that somewhere this afternoon.

@JayWood
Copy link
Member

JayWood commented Jan 24, 2016

I've ran the command numerous times this morning, cannot duplicate.

@ethsmith
Copy link

@JayWood I fixed it in the commit I made a few days ago

@HappyHarm
Copy link
Contributor Author

Just tried the newest build and it looks like it's still not fixed

@ethsmith
Copy link

ethsmith commented Feb 8, 2016

@HappyHarm it's weird, for some reason people that used the alpha builds say this still happens (mmuziek tried so many times that I guess it flushed the cached data and started working correctly for him) I am trying to find a Java command that deletes cached data or build info for earlier jars

@ethsmith
Copy link

ethsmith commented Feb 8, 2016

It may be the fact that the code says that 'key' only instead of pointing at 'WooMinecraft.web.key' it's a location statement and I'm sure I changed it to be 'WooMinecraft.web.key' and @JayWood changed the code in the register command back to just 'key' but I'm not sure why

@ethsmith
Copy link

ethsmith commented Feb 8, 2016

I am working on a few things and will push them to dev nightly later today

@HappyHarm
Copy link
Contributor Author

Ok then, thanks for the quick response :)

@JayWood
Copy link
Member

JayWood commented Feb 8, 2016

@TekkitCommando WooMinecraft.web.key was the nested config, and the config is no longer nested.

@JayWood JayWood reopened this Feb 8, 2016
@ethsmith
Copy link

ethsmith commented Feb 8, 2016

@JayWood Ah ok, that's how I know the data is cached on my server then cuz it is still nested for me even with the new jar.

@JayWood
Copy link
Member

JayWood commented Feb 8, 2016

@TekkitCommando I believe the issue may be with saveConfig here:

Maybe we have to get the entire config, and then write it?

@ethsmith
Copy link

ethsmith commented Feb 8, 2016

@JayWood I don't see why you would, it worked fine before. plugin.saveConfig() should work fine and setting the key shouldn't effect the other config options. I don't see you having to do plugin.getConfig().saveConfig(); but I mean you could try

@JayWood
Copy link
Member

JayWood commented Feb 8, 2016

@TekkitCommando I can't do anything until after work today, it's currently 9AM, so nothing from me until 5PM [ GMT -5 ]

Admittedly I didn't test that command my bad I'm used to having a full QA team at my side 😄 If you have time give it a go, if not I'll have a look after work.

@ethsmith
Copy link

ethsmith commented Feb 8, 2016

@JayWood I don't think that .getConfig().saveConfig() will even work actually xD I will give it a try :P Oh yeah a job, I need to get one of those things. Maybe I will find a job in Python development or PHP/Java after I finish my classes lol

@ethsmith
Copy link

ethsmith commented Feb 8, 2016

@JayWood I tested my theory of using getConfig and saveConfig and it was a fail :/

@JayWood
Copy link
Member

JayWood commented Feb 29, 2016

@TekkitCommando @HappyHarm is this still a thing?

@ethsmith
Copy link

I am not sure, my computer is not working correctly, I bought some parts to fix it and then I will get the latest jar and test this. Sorry for the inactivity, like I said I bought some parts so maybe I will have the JDK installed today and be back to code again :D

@HappyHarm
Copy link
Contributor Author

Idk my hosting got cleared a week ago and didn't got time to re-setup everything. Maybe I can test it this evening, if I forgot remember me about it :P

@HappyHarm
Copy link
Contributor Author

Yep issue is still here. Sorry for the delay, forgot it as expected :P

@ethsmith
Copy link

ethsmith commented Mar 2, 2016

I will restructure the config code today if i get the time :)

@JayWood JayWood added this to the 1.0.5-RC1 milestone Jun 13, 2016
@ethsmith
Copy link

@JayWood This was fixed right?

@JayWood
Copy link
Member

JayWood commented Jun 13, 2016

No, purely added a todo to look into it.

@ethsmith
Copy link

@JayWood 0-0 Ok I will fix it real quick.

@JayWood
Copy link
Member

JayWood commented Jun 24, 2016

@TekkitCommando - this is now fixed. Though has yet to be merged into master.

@JayWood JayWood added the Fixed label Jun 24, 2016
@ethsmith
Copy link

@JayWood I ended up changing the code that should have fixed it but my freakin git would not work for the life of me. :P

@JayWood
Copy link
Member

JayWood commented Jun 24, 2016

@TekkitCommando if that happens again it'd be great if you can at least gist up the file and link it in the task, I'd be glad to copy it in. It's better than letting tasks go stagnant for months I'd say.

@ethsmith
Copy link

No it was like 3 days ago. My git was working a couple weeks ago.

@ethsmith
Copy link

It's working again now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants