Skip to content
This repository has been archived by the owner on Jan 28, 2023. It is now read-only.

added bungee support #206

Closed
wants to merge 6 commits into from
Closed

Conversation

Peda1996
Copy link

Well,
I just added bungee support as I needed it for my server.
(i haven't tested starting without a config yet, but I think it will work, as the config is inside the resources.)

Enjoy

spannerman79 and others added 3 commits November 18, 2019 05:47
dev-nightly fork was removed - updating to point towards master
@Peda1996 Peda1996 mentioned this pull request Dec 30, 2019
@Peda1996
Copy link
Author

How can I create a pull request for the dev branch?

@spannerman79
Copy link
Contributor

@JayWood needs to update the contributing docs, there was a dev branch. Unsure if a dev branch will come back to be used or not.

@JayWood JayWood self-requested a review December 31, 2019 00:37
@JayWood JayWood changed the base branch from master to release/1.3.0 December 31, 2019 01:00
@JayWood
Copy link
Member

JayWood commented Dec 31, 2019

Base updated to release branch, no more dev branches, mainly cuz it was just me so 🤷‍♂

@spannerman79
Copy link
Contributor

The only thing I can see that is missing is documentation needed to send the required command to a specific server. If indeed you are using bungee then 99% sure you would be running more then just two servers.

@Peda1996
Copy link
Author

Peda1996 commented Jan 4, 2020

That shouldn't be a big problem, as you can create different keys for different servers, therefore only use a different key for the bungee server, add the serverkey into your wordpress and you're ready to go.

Therefore sending to individual servers is possible with setting up keys per server.

@spannerman79
Copy link
Contributor

spannerman79 commented Jan 4, 2020

True - although if you look at the number of issues that have been created that were either an issue with someones web server, or not reading/setting firewall excpetions if they use Cloudflare (even though its in both in wiki and also a note in issue creation), or using redirects (mentioned in FAQ wiki)... I can keep going on lol

So yes - documentation will need to be done if/when @JayWood accepts the PR.

Edit: I would happily test this if WooMinecraft still supported 1.7.10. Right now I use https://www.spigotmc.org/resources/9854/ as 1.7.10 support was removed in 1.1.0

@ethsmith
Copy link

@spannerman79 Did you try on 1.7.10 and it didn't work or did Jay just remove it from officially supported versions?

Also, if he tested this and it worked, why hasn't it been accepted?

@spannerman79
Copy link
Contributor

Did you try on 1.7.10 and it didn't work

Obvioulsy I have tried and yes it doesn't work on 1.7.10....
I wouldn't have stated otherwise.

@JayWood
Copy link
Member

JayWood commented Jan 21, 2020

I've not tested it, that's why it's not been accepted yet. I am also working on other things, so there's that. Once i have the drive to circle back around and setup a testing environment for bungee I'll merge if all is well.

@JayWood JayWood added this to the Next Release milestone Feb 13, 2021
@JayWood
Copy link
Member

JayWood commented Dec 19, 2021

I believe this was resolved with #256 - closing for now.

@JayWood JayWood closed this Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants