Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slider for right-to-left configurations #57

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Fix slider for right-to-left configurations #57

merged 1 commit into from
Sep 26, 2018

Conversation

diegoserranoa
Copy link
Contributor

Forces the slider to go left-to-right

How to test

  1. Fire the iOS simulator, go to Settings -> General -> Language & Region and select iPhone Language, select Hebrew and Done
  2. In master, setup the SDK with your account_token and clientId in ViewController.m
  3. In Xcode, click on the WootricSDK-Demo item in the Project Navigator.
  4. Now select WootricSDK-Demo project from the dropdown and select the Build Settings tab.
  5. Under Localizations, click on the + and add Hebrew language.
    screen shot 2018-09-25 at 11 45 35 am
  6. If you run the app now and see the survey, the slider would go the wrong way.
  7. Checkout this branch
  8. Run app again and everything should be working fine.

Trello

https://trello.com/c/TvozRrLL/3536-2-ios-survey-bug-the-bar-goes-the-wrong-way-watch-video

marinhero
marinhero approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@marinhero marinhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this got fixed. :shipit:

Before:
screen shot 2018-09-26 at 12 38 43 pm

After:
screen shot 2018-09-26 at 12 42 03 pm

Result:

screen shot 2018-09-26 at 12 44 56 pm

@diegoserranoa diegoserranoa merged commit fb5960b into master Sep 26, 2018
@diegoserranoa diegoserranoa deleted the ds-fix-slider-rtl branch September 26, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinhero marinhero marinhero approved these changes

Assignees
No one assigned
Labels
ready to merge reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diegoserranoa @marinhero