Fix slider bug #65
Merged
Fix slider bug #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Who's qualified to review this? |
|
@hachibu usually @prabhatjha takes a look at the code or @marinhero who knows a little bit of Objective-c, I think 😄 |
|
@diegoserranoa cool, I assigned them to this. |
prabhatjha
reviewed
Jun 4, 2019
| @@ -63,7 +63,8 @@ - (instancetype)initWithSuperview:(UIView *)superview viewController:(UIViewCont | |||
| [self setThumbImage:image forState:UIControlStateHighlighted]; | |||
| [self setTranslatesAutoresizingMaskIntoConstraints:NO]; | |||
| [self addTarget:superview action:NSSelectorFromString(@"updateSliderScore:") forControlEvents:UIControlEventValueChanged]; | |||
| UITapGestureRecognizer *gr = [[UITapGestureRecognizer alloc] initWithTarget:viewController action:NSSelectorFromString(@"sliderTapped:")]; | |||
| UILongPressGestureRecognizer *gr = [[UILongPressGestureRecognizer alloc] initWithTarget:viewController action:NSSelectorFromString(@"sliderTapped:")]; | |||
There was a problem hiding this comment.
So was it working with tap before but not with long press? Now it will work with long press but not tap ? @diegoserranoa
There was a problem hiding this comment.
@prabhatjha that's why I'm setting the minimumPressDuration to 0 in the next line. So no matter if it's a tap or a long press, the sliderTapped method would be called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix slider bug when first selecting 0 and then sliding to other values caused the SEND button not to be enabled.
Changes
Test
Internal Trello Ref: link