Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with TwentySeventeen theme #1353

Closed
DevinWalker opened this issue Dec 21, 2016 · 0 comments
Closed

Compatibility with TwentySeventeen theme #1353

DevinWalker opened this issue Dec 21, 2016 · 0 comments
Assignees
@DevinWalker
Milestone
1.7.2

Comments

@DevinWalker
Copy link
Member

Issue Overview

The single Give form page is bumping to full width incorrectly due to the custom wrappers being used on the single page:

2016-12-21_10-35-43

Expected Behavior

The single form page shares the same width as others.

Current Behavior

It bumps to full-width.

Possible Solution

Add custom template wrapper for TwentySeventeen.
@DevinWalker DevinWalker added this to the 1.7.2 milestone Dec 21, 2016
@DevinWalker DevinWalker self-assigned this Dec 21, 2016
DevinWalker pushed a commit that referenced this issue Dec 21, 2016
Added wrappers for twenty-seventeen #1353
7c0103e
DevinWalker pushed a commit that referenced this issue Dec 21, 2016
Added inline style fix for payment gateway radios bumping to two line…
2225180 
…s - this brings over a fix that was introduced in #1258 to 1.7.2 via #1353
@DevinWalker DevinWalker mentioned this issue Dec 21, 2016
Merged
3 tasks
@DevinWalker DevinWalker mentioned this issue Dec 21, 2016
Closed
2 tasks
DevinWalker pushed a commit that referenced this issue Dec 21, 2016
Merge branch 'release/1.7.2' into release/1.8
e52078a 
* release/1.7.2:
  i18n standardized word usage #1349
  i18n dupe fix #1349
  i18n dupe fix #1349
  i18n dupe fix #1349
  i18n dupe fix #1349
  i18n dupe #1349
  i18n dupe #1349
  Fixed i18n dupe #1349
  i18n duplicate of “Address 1” and “Address 1:” #1349
  Compiled styles
  Added inline style fix for payment gateway radios bumping to two lines - this brings over a fix that was introduced in #1258 to 1.7.2 via #1353
  Added wrappers for twenty-seventeen #1353

# Conflicts:
#	assets/js/frontend/give.all.min.js
#	assets/scss/frontend/forms.scss
#	assets/sourcemaps/give.css.map
#	includes/admin/forms/metabox.php
#	includes/gateways/paypal-standard.php
#	templates/give-rtl.min.css
#	templates/give.min.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

Labels
None yet
Projects
None yet
Milestone
1.7.2
Development

No branches or pull requests
1 participant
@DevinWalker