Add some guidelines for how to test well you code before creating PR #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinderk
force-pushed
the
hotfix/contributing
branch
from
5d2df36
to
4e880cf
Compare
DevinWalker
reviewed
Aug 22, 2017
CONTRIBUTING.md
Outdated
| @@ -71,3 +71,12 @@ Follow the steps below to configure ESLint with PHPStorm: | |||
| Open any JS file and you'll see suggestions from ESLint, if any. | |||
|
|
|||
| That's all! You're done. | |||
|
|
|||
| ## How to test code before creating PR | |||
| You can create a awesome PR if: | |||
DevinWalker
reviewed
Aug 22, 2017
CONTRIBUTING.md
Outdated
|
|
||
| ## How to test code before creating PR | ||
| You can create a awesome PR if: | ||
| 1. `debug.log` is empty after testing code functionality. |
There was a problem hiding this comment.
The debug.log found in /wp-content/
DevinWalker
reviewed
Aug 22, 2017
CONTRIBUTING.md
Outdated
| ## How to test code before creating PR | ||
| You can create a awesome PR if: | ||
| 1. `debug.log` is empty after testing code functionality. | ||
| 2. Do not contain any testing purpose code. |
There was a problem hiding this comment.
"Does not contain and testing code like var_dump() and console.log()
DevinWalker
reviewed
Aug 22, 2017
CONTRIBUTING.md
Outdated
| You can create a awesome PR if: | ||
| 1. `debug.log` is empty after testing code functionality. | ||
| 2. Do not contain any testing purpose code. | ||
| 3. Passes all phpunit test. |
DevinWalker
reviewed
Aug 22, 2017
CONTRIBUTING.md
Outdated
| 1. `debug.log` is empty after testing code functionality. | ||
| 2. Do not contain any testing purpose code. | ||
| 3. Passes all phpunit test. | ||
| 4. No formatting issue while check formatting `php_codesniffer`/`eslint` with `WordPress Coding Standard`. |
There was a problem hiding this comment.
"issues when checking formatting via"
DevinWalker
reviewed
Aug 22, 2017
CONTRIBUTING.md
Outdated
| 2. Do not contain any testing purpose code. | ||
| 3. Passes all phpunit test. | ||
| 4. No formatting issue while check formatting `php_codesniffer`/`eslint` with `WordPress Coding Standard`. | ||
| 5. Works fine at least on PHP `5.3` and PHP `7.*` |
|
@DevinWalker grammatical changes done. |
DevinWalker
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.