Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[give_form] ShortCode should support Featured Image #2231

Closed
2 tasks
mehul0810 opened this issue Oct 24, 2017 · 1 comment
Closed
2 tasks

[give_form] ShortCode should support Featured Image #2231

mehul0810 opened this issue Oct 24, 2017 · 1 comment

Comments

@mehul0810
Copy link
Contributor

Issue Overview

It seems that featured image of donation form is display as a part of CPT single page. But, not as a part of ShortCode.

gif

Expected Behavior

Featured Image of the donation form should be displayed in shortcode as well.

Current Behavior

ShortCode doesn't display featured image.

Possible Solution

Adding support of featured image to give_get_donation_form function.

Steps to Reproduce (for bugs)

  1. Install Give (Latest Version)
  2. Create New Donation Form
  3. Add Featured Image to Donation Form
  4. Create New Page
  5. Add Newly Created Donation Form ShortCode to the Page
  6. Open the Page in Front End.
  7. You'll notice there is no featured image.

Related Issues and/or PRs

#1414

Todos

  • Tests
  • Documentation
@DevinWalker
Copy link
Member

Hmm, we sometimes get this question about why the feature image isn't displaying within the shortcode. I've mostly just said that you can easily add the image next to where you are embedding the shortcode or display it using the donation form content editor.

The featured image seems better off remaining with the single post page template for now unless there's a great outline of how it could be used within the shortcode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants